Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to JSON utility methods in rest_framework.utils #633

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add type hints to JSON utility methods in rest_framework.utils #633

merged 1 commit into from
Jul 3, 2024

Conversation

DongwookKim0823
Copy link
Contributor

I have made things!

This pull request adds type hints to the JSON utility methods in the rest_framework.utils.json module. The changes include specifying the types for dump, dumps, load, and loads methods. This enhancement improves code readability and provides better support for static type checkers.

sobolevn
sobolevn approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit cce59b5 into typeddjango:master Jul 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DongwookKim0823 @sobolevn